to reject the event #83
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The [issue 77] (yohang#77) explain the problem. I suggest this change to resolve it.
|
@ahurt2000 Do we really want a |
|
hum good question! may is better a TransitionException |
|
Well, there's another way to approach it ignoring the event status as before. But then it makes sense that the event is rejected? |
|
I’m 👍 for this PR..just not sure whether to throw an Exception or fail silently ( |
|
Well..failing silently is not a good idea - nevermind. |
|
Hum, sorry for taking this so late, but does it makes sense to reject a pre transition event ? I think the real problem comes from the current implementation, that allow that. In fact, we can reject a post transition event… 2.0 version will probably split TestTransition and ApplyTransition events. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue 77 explain the problem. I suggest this change to resolve it.